Review dependency management

[bclozel]

Given the layout of this starter (you've separated the auto-configuration and the actual starter), the autoconfigure module should not have a compile dependency on docker-java, it should be optional.

Only the starter should bring that dependency.

[jliuold]

The project dependencies have been improved. Now both docker-java and docker-client are optional. User can chose one item.

[bclozel]

There's been a misunderstanding.
It seems that you've now merged your auto-configuration and your starter into a single project - given the size of the auto-configuration, I don't think it's a bad idea.

Now your starter should absolutely come with compile dependencies; adding your starter to a Spring Boot application, without any other action from the developer, should do something.

Note: spring-boot-configuration-processor should be marked as optional, as it's only useful when you build your project (to generate the configuration metadata). But projects depending on this starter don't need this dependency.

[jliuold]

Hi!
Should Both docker-java and docker-client's dependencies are optional? If both are optional, the starter does nothing after adding the starter dependency without adding other dependency.

[bclozel]

I've read the README file in your repository. At that point I think it's up to you.
If you think your starter should have a default opinion, then mark one of the dependencies as compile but then document how to switch to the other one. If you think it's really the developer's choice and your starter does not favor one over the other, then marking both as optional (but still providing dependency management for them!) is fine.

[jliuold]

Thank you!
The spring-boot-configuration-processor has been marked as optional now.

[bclozel]

Thanks!