Add convenience methods in FlatFileItemWriterBuilder to generate delimited/fixedLength files #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mited files Resolves BATCH-2696
…atted files Resolves BATCH-2696
mminella
reviewed
Aug 31, 2018
Member
mminella
left a comment
mminella
left a comment
There was a problem hiding this comment.
Can we get a test that covers a delimited file but uses the default delimiter?
Contributor
Author
|
Added test in 4da50ba to cover generating a delimited file with the default delimiter. |
mminella
reviewed
Aug 31, 2018
| public FlatFileItemWriterBuilder<T> names(String[] names) { | ||
| this.names.addAll(Arrays.asList(names)); | ||
| return this.parent; | ||
| } |
Member
There was a problem hiding this comment.
It would be nice to have a vargs option as well...
Contributor
Author
There was a problem hiding this comment.
I took the same approach as the FlatFileItemReaderBuilder to be consistent.
We can add this for both reader and writer builders in another step.
mminella
reviewed
Aug 31, 2018
| public FlatFileItemWriterBuilder<T> names(String[] names) { | ||
| this.names.addAll(Arrays.asList(names)); | ||
| return this.parent; | ||
| } |
Member
There was a problem hiding this comment.
It would be nice to have a vargs option as well...
Member
|
Rebased, squashed, and merged as e83ed1d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATCH-2696.