This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Replace RabbitAutoConfiguration with local RabbitConfiguration #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Jun 20, 2021
...src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitConfiguration.java
Show resolved
Hide resolved
onobc
commented
Jun 20, 2021
...src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
changed the title
onobc
force-pushed
the
gh-187-wip
branch
4 times, most recently
from
30591d6 to
8d1d7ca
Compare
|
@garyrussell @sabbyanandan this one is ready for review. |
|
LGTM; but shouldn't we rename |
|
Thx @garyrussell . I too agree we should rename it to I just was not sure about putting it in w/ this current proposal. |
|
Yes; it's ok to do it in this PR. |
|
@Bono007 Many thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on https://github.com/spring-projects/spring-boot/pull/26982/files
@wilkinsona
Fixes #187