Break dependence on RabbitAutoConfiguration #179
Conversation
| $$data-username$$:: $$Username of the database to execute DML scripts (if different).$$ *($$String$$, default: `$$<none>$$`)* | ||
| $$driver-class-name$$:: $$Fully qualified name of the JDBC driver. Auto-detected based on the URL by default.$$ *($$String$$, default: `$$<none>$$`)* | ||
| $$embedded-database-connection$$:: $$Connection details for an embedded database. Defaults to the most suitable embedded database that is available on the classpath.$$ *($$EmbeddedDatabaseConnection$$, default: `$$<none>$$`, possible values: `NONE`,`H2`,`DERBY`,`HSQL`,`HSQLDB`)* | ||
| $$embedded-database-connection$$:: $$Connection details for an embedded database. Defaults to the most suitable embedded database that is available on the classpath.$$ *($$EmbeddedDatabaseConnection$$, default: `$$<none>$$`, possible values: `NONE`,`H2`,`DERBY`,`HSQLDB`)* |
There was a problem hiding this comment.
[UNRELATED+BOOT26] this same comment applies to all changes in any README files.
| .getCompleteConfiguration(RedisSinkTestApplication.class)) | ||
| .web(WebApplicationType.NONE) | ||
| .run("--spring.cloud.function.definition=redisConsumer", | ||
| "--spring.cloud.compatibility-verifier.enabled=false", |
There was a problem hiding this comment.
[UNRELATED+BOOT26+TEMPORARY] Spring Boot 2.6. Spring Cloud balks at any attempt to use > 2.5
| */ | ||
| @SpringBootTest(properties = { | ||
| "spring.data.mongodb.port=0", | ||
| "spring.mongodb.embedded.version=4.0.12", |
There was a problem hiding this comment.
[UNRELATED+BOOT26]
The default embedded MongoDB version has been removed in 2.6.
- This comment applies to all instances of this being set in tests
- There is probably a more general place to set this than here and in each test.
| import org.springframework.messaging.MessageHandler; | ||
|
|
||
| /** | ||
| * A configuration for RabbitMQ Consumer function. Uses a |
There was a problem hiding this comment.
[NOTE] I reverse-engineered this comment from git history.
| private RabbitProperties rabbitProperties; | ||
|
|
||
| @Autowired | ||
| private ObjectProvider<ConnectionNameStrategy> connectionNameStrategy; |
There was a problem hiding this comment.
This was only in here to appease the signature of the connection factory creator. The code immediately turned arounds and overrides the naming strategy so I removed this.
| private RabbitProperties bootProperties; | ||
|
|
||
| @Autowired | ||
| private ObjectProvider<ConnectionNameStrategy> connectionNameStrategy; |
There was a problem hiding this comment.
This was only in here to appease the signature of the connection factory creator. The code immediately turned arounds and overrides the naming strategy so I removed this.
|
Original forked branch was deleted - reworked in new fork - excluding all boot 26 and doc commits that were in this PR. |
1 participant
This code proposal breaks the dependence on RabbitAutoConfiguration for the
rabbit-consumerandrabbit-supplierfunctions.@sabbyanandan @garyrussell this is the
streams-applicationcounterpart to the spring-cloud-stream-rabbit-binder one.