Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Spicetify version in README & check for version in code #5

Closed
elijaholmos opened this issue Apr 26, 2021 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@elijaholmos
Copy link
Member

Certain features rely on certain Spicetify versions. Include which version(s) are supported by this extension in the README and perform a check when the extension is initializing to ensure it is being used with a compatible Spicetify version.

@elijaholmos
Copy link
Member Author

It would appear that the Spicetify version is not stored anywhere that is accessible by javascript; the only place I can find is in the .go files

@elijaholmos
Copy link
Member Author

This is about as resolved as I can get it at the moment. It's not entirely necessary for the spicetify version to be checked in the extension code, but it'll just make troubleshooting harder on the user's end. Still though, I don't foresee much issues since one of the first things that can be checked in support tickets is the user's currently running version of spicetify.

@elijaholmos elijaholmos self-assigned this May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant