Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Loading notification can create an illusion of successful initialization #6

Open
elijaholmos opened this issue Apr 27, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@elijaholmos
Copy link
Member

Not necessarily a bug per se, but each blue loading notification that appears while VPWS is initializing only lasts for 2-3 seconds before it fades away. Given how the percents are calculated and when the notifications are fired, this may mean that a notification appears with a status, say 78%, then fades away with no notification to follow it for several seconds. As a user, this can be confusing.

Requirements:
-Make each notification displayed during the setup process last until the next notification is ready to be displayed

Solution Brainstorm:
-When a new notification is displayed, create a setTimeout to keep displaying that notification with the exact same text that loops every 2-3 seconds. When the next notification is ready to be displayed, cancel the previous setTimeout and create a new timeout for the next notification. Repeat this process until 100% is achieved.

BONUS: Add a way to display initialization errors to the user, in the event that one is encountered. Example of an error could include an incompatible version of Spicetify; see #5

@elijaholmos elijaholmos added the bug Something isn't working label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant