Testing refactors

[unmonk]

Resolves #18

Also adds the start of tennis: getScoreboard

This should fix tests so they are actually running, and fixes any issues that arose.
There are some issues lingering with some of the cdn based calls returning unparsed html, and 404 on the ranking ones.

If you run an npm test locally, you should see a report in
mochawesome-report/mochawesome.html

I've verified things are still working as expected for the few calls I use, but I have not thoroughly tested each one. Would rely on the community for that.

 140 passing (59s)
  11 failing

  1) MBB Rankings
       should populate rankings for the current week and year:
     Error: Request failed with status code 404


  2) MBB Rankings
       should populate rankings for the given week and year:
     Error: Request failed with status code 404


  3) MBB Rankings
       should return a promise for rankings for the current week and year:
     Error: Request failed with status code 404

  4) MBB Rankings
       should return a promise for rankings for the given week and year:
     Error: Request failed with status code 404


  5) MBB Recruiting
       should return a promise for a school's commit list for a given year:
     Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/dev/sportsdataverse-js/test/mbb.test.js)


  6) NCAA Games
       should return a promise for ncaa game team stats for a given game:
     Error: Request failed with status code 404


  7) NCAA Games
       should return a promise for ncaa game scoring summary for a given game:
     Error: Request failed with status code 404


  8) WBB Rankings
       should populate rankings for the current week and year:
     Error: Request failed with status code 404


  9) WBB Rankings
       should populate rankings for the given week and year:
     Error: Request failed with status code 404


  10) WBB Rankings
       should return a promise for rankings for the current week and year:
     Error: Request failed with status code 404

  11) WBB Rankings
       should return a promise for rankings for the given week and year:
     Error: Request failed with status code 404
     

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sportsdataverse-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2023 0:50am

[saiemgilani]

Two notes:

• Remove this rankings.json file, I believe that was not intended to be included?
• I am wondering if tnns is a bit too cute for an abbreviation of a service? I feel like the most clear and obvious (if verbose) name would be tennis. Given that the name of the service also winds up being in the url, it is probably prudent to change it to tennis

NB: since you're now a member (and admin user) of the SDV org, please just make future PR's on the SDV org repo

General Comments:
I really love the mochawesome report you added, as well as all the changes you've made thus far. I have solves for the rankings functions (and the recruiting stuff.. but that'll take a little more involved doing), but the NCAA stuff will probably need some fixes or less rigor possibly once I fully investigate the test cases. Your contributions are super appreciated and I'm glad you were able to implement the should library change for testing without any issue. Took a bit off my plate that I would have dragged my feet on.

[unmonk]

• Removed that extra json file, that was left in by accident.
• Renamed tnns to tennis

NB = nota bene?