Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not failing #18

Closed
unmonk opened this issue Jun 20, 2023 · 1 comment · Fixed by #19
Closed

Tests not failing #18

unmonk opened this issue Jun 20, 2023 · 1 comment · Fixed by #19

Comments

@unmonk
Copy link
Contributor

unmonk commented Jun 20, 2023

Working through adding tennis and I noticed that tests are not working as I expected. Always showing me a success, even when the URL is screwed up.

The promises seem to return after mocha spits out a success as well.

I'll look into mocha/chai and see what's going on. Not overly familiar with either.

My editor sees should as unused, so maybe there's a syntax issue here somewhere. I should have some time to look at it later tonight.

image

image

@unmonk
Copy link
Contributor Author

unmonk commented Jun 20, 2023

Seems to be the same across them all.
image

these null/NaN urls are returning
{ "code": 400, "message": "Failed to get events endpoint." }

From the endpoint. We probably shouldn't be passing those.

Are you seeing this on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant