feat(reference/kubernetes): max-version-history docs #827
Conversation
|
|
||
| When set to a non-negative integer, this configures how many versions of a | ||
| resource to keep around. When more than `max-version-history` versions of a | ||
| Kubernetes artifact exist, Spinnaker deletes all older versions. |
There was a problem hiding this comment.
Doesn't just delete the oldest each time? From 1 version to max number of them, then back to 1 each time?
There was a problem hiding this comment.
Usually it does, but if you either go from not having this property set to setting it, or shrink the number, more than 1 will be deleted.
| a Deployment is managing, that is configured by | ||
| [`spec.revisionHistoryLimit`](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy). | ||
| If instead Spinnaker is deploying ReplicaSets directly without a Deployment, | ||
| this annotation does the job. |
There was a problem hiding this comment.
I wonder if there's a way to get this information at the top of the section, the use case for this property contrasted with the other property, before the "When set to a non-negative integer..." information.
There was a problem hiding this comment.
I added this to clear up a potential confusion, I don't think this in particular should go at the top. In general I feel with the reference docs we can be a little more abstract. Maybe we should have a guide for this?
There was a problem hiding this comment.
Cool by me. At first glance I don't see an obvious place in your existing k8sv2 guide for this. Feel free to follow up with me about what might be written there, but I'm ok with leaving this here.
There was a problem hiding this comment.
I've assigned myself to a new guide to handle this: #829
I imagine it'll be pretty short & look similar to one of these: https://www.spinnaker.io/guides/user/kubernetes-v2/deploy-manifest/
No description provided.