feat(provider/kubernetes): max-version-history annotation #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimanyi
approved these changes
Jun 4, 2018
danielpeach
reviewed
Jun 4, 2018
|
@danielpeach we could think about implementing with resource pointers for more fine-grained control down the road, but that is largely infeasible when dealing with large bundles of resources, especially in cases where not all resources are submitted to a deploy stage each time. |
ghost
approved these changes
Jun 4, 2018
| @@ -79,4 +79,7 @@ | |||
| public static final String PAUSE_ROLLOUT_MANIFEST = "pauseRolloutManifest"; | |||
| public static final String RESUME_ROLLOUT_MANIFEST = "resumeRolloutManifest"; | |||
| public static final String UNDO_ROLLOUT_MANIFEST = "undoRolloutManifest"; | |||
|
|
|||
| // Aritfact operations | |||
| .collect(Collectors.toList()); | ||
|
|
||
| KubernetesManifestStrategy strategy = KubernetesManifestAnnotater.getStrategy(manifest); | ||
| if (strategy.getMaxVersionHistory() == null) { |
There was a problem hiding this comment.
Minor nit: It doesn't look like we need to execute lines 98 - 102 if strategy.getMaxVersionHistory() is null. This code could go at the start of the function to avoid unnecessary work.
Added to make cleanup of versioned resources simpler
lwander
force-pushed
the
k8s-max-version-history
branch
from
a513044
to
5c28204
Compare
tomaslin
pushed a commit
to tomaslin/clouddriver
that referenced
this pull request
Jun 5, 2018
…2688) Added to make cleanup of versioned resources simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.