fix & refactor(cloud-config-server): Issue with non-existing file/folder location used in spring cloud config server properties while upgrading spring boot 2.4.x. #1002
Conversation
| implementation project(':kork-secrets') | ||
| implementation "org.springframework.cloud:spring-cloud-context" | ||
| implementation "org.springframework.cloud:spring-cloud-config-server" | ||
| implementation "io.awspring.cloud:spring-cloud-aws-context:2.3.5" | ||
|
|
||
| testImplementation "org.springframework.boot:spring-boot-starter-test" | ||
| testImplementation "org.springframework.cloud:spring-cloud-starter-bootstrap" |
There was a problem hiding this comment.
Don't all users of kork-cloud-config-server need to specify org.springframework.cloud:spring-cloud-starter-bootstrap as a dependency? We'd make their lives easier by making it a runtimeOnly dependency too, yes? And I bet here, testRuntimeOnly is sufficient since nothing needs this to compile, right?
There was a problem hiding this comment.
Update the dependency as testRuntimeOnly
There was a problem hiding this comment.
What do you think about adding runtimeOnly org.springframework.cloud:spring-cloud-starter-bootstrap ?
There was a problem hiding this comment.
org.springframework.cloud:spring-cloud-starter-bootstrap is a marker dependency to enable the bootstrap of cloud config server (which is disabled by default) for spring-cloud-2020.0-Release. I agree with your concern that testRuntimeOnly will not transport this marker dependency to other spinnaker components for cloud config server startup and we should go for runtimeOnly.
However, I tried other option of introducing spring.cloud.bootstrap.enabled=true, as mentioned here, it is working successfully (tested on halyard by removing this) and seems to be better option. Please suggest.
There was a problem hiding this comment.
Update the property.
j-sandy
force-pushed
the
sb-upgrade-2-4-13-cloud-config-import
branch
2 times, most recently
from
beff73d
to
016f001
Compare
| @@ -6,6 +6,7 @@ dependencies { | |||
|
|
|||
| implementation "commons-io:commons-io" | |||
| implementation "org.apache.commons:commons-lang3" | |||
| implementation project(':kork-config') | |||
There was a problem hiding this comment.
I tried this locally and it looks like this only needs to be
| implementation project(':kork-config') | |
| testImplementation project(':kork-config') |
so DefaultPropertiesBuilder is available to ConfigServerTestApplication.
There was a problem hiding this comment.
Updated the dependency as suggested.
…der location used in spring cloud config server properties while upgrading spring boot 2.4.x. With spring boot 2.4, spring cloud config server location properties will no longer fail silently if the file or folder does not exist. Now, requires prefix "optional:" for the location. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#config-file-processing-application-properties-and-yaml-files Added testcase in support of code change to introduce "optional:" prefix for location properties.
j-sandy
force-pushed
the
sb-upgrade-2-4-13-cloud-config-import
branch
from
016f001
to
e094334
Compare
Now that spinnaker/kork#990 and spinnaker/kork#1002 are in (and halyard consumes them), we don't need these changes here anymore. Revert "fix(web): adjust configuration so that the halyard daemon starts with spring boot 2.4 (spinnaker#1987)" This reverts commit 4428105.
Now that spinnaker/kork#990 and spinnaker/kork#1002 are in (and halyard consumes them), we don't need these changes here anymore. Revert "fix(web): adjust configuration so that the halyard daemon starts with spring boot 2.4 (#1987)" This reverts commit 4428105.
* fix(config): Issue with non-existing file/folder location used in Spring properties while upgrading spring boot 2.4.x. (spinnaker#990) With spring boot 2.4, spring location properties will no longer fail silently if the file or folder does not exist. Now, requires prefix "optional:" for the location. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#config-file-processing-application-properties-and-yaml-files And introducing new spring additional data importing property suggested in the links below, to be used with Spring boot 2.4: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-Config-Data-Migration-Guide https://docs.spring.io/spring-boot/docs/2.4.0/reference/html/spring-boot-features.html#boot-features-external-config-files-importing Added testcase in support of code change to introduce "optional:" prefix for location properties. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> @W-12236865 * fix & refactor(cloud-config-server): Issue with non-existing file/folder location used in spring cloud config server properties while upgrading spring boot 2.4.x. (spinnaker#1002) With spring boot 2.4, spring cloud config server location properties will no longer fail silently if the file or folder does not exist. Now, requires prefix "optional:" for the location. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#config-file-processing-application-properties-and-yaml-files Added testcase in support of code change to introduce "optional:" prefix for location properties. @W-12236865 Co-authored-by: Sandesh <[email protected]>
With spring boot 2.4, spring cloud config server location properties will no longer fail silently if the file or folder does not exist. Now, requires prefix "optional:" for the location.
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#config-file-processing-application-properties-and-yaml-files
Added testcase in support of code change to introduce "optional:" prefix for location properties.