Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): clean up spring boot 2.4-related changes #2006

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

dbyron-sf
Copy link
Contributor

Now that spinnaker/kork#990 and spinnaker/kork#1002 are in (and halyard consumes them), we don't need these changes here anymore.

Revert "fix(web): adjust configuration so that the halyard daemon starts with spring boot 2.4 (#1987)"

This reverts commit 4428105.

Now that spinnaker/kork#990 and
spinnaker/kork#1002 are in (and halyard consumes them), we don't
need these changes here anymore.

Revert "fix(web): adjust configuration so that the halyard daemon starts with spring boot 2.4 (spinnaker#1987)"

This reverts commit 4428105.
@j-sandy j-sandy self-requested a review December 20, 2022 12:29
Copy link
Contributor

@j-sandy j-sandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the build, execution of test cases and runtime instance of halyard service. All passed.
LGTM !

@j-sandy j-sandy merged commit 9026731 into spinnaker:master Dec 20, 2022
@dbyron-sf dbyron-sf deleted the clean-up-spring-boot-2.4 branch December 21, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants