Component filtering e2e test#328
Merged
calebschoepp merged 2 commits intospinframework:mainfrom Nov 1, 2024
Merged
Conversation
kate-goldenring
force-pushed
the
component-filtering-e2e
branch
from
905c79b to
241037e
Compare
kate-goldenring
requested review from
bacongobbler,
calebschoepp,
endocrimes,
michelleN and
rajatjindal
as code owners
calebschoepp
approved these changes
Oct 28, 2024
Contributor
calebschoepp
left a comment
calebschoepp
left a comment
There was a problem hiding this comment.
Nice work. All non-blocking comments.
kate-goldenring
force-pushed
the
component-filtering-e2e
branch
from
241037e to
ffe4e66
Compare
Contributor
Author
|
marking as ready for review -- readiness for merging is dependent on this discussion #328 (comment) |
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
component-filtering-e2e
branch
from
ffe4e66 to
cd5ab7d
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
component-filtering-e2e
branch
from
6893e1c to
4dd579c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until #323 merges and new version of the shim is released. For now this updates the tests to point to a canary release of the shim (in k3d).