feat: support only running a subset of components of a Spin app

[kate-goldenring]

Draft until support for executing only a set of components is merged in the shim: spinframework/containerd-shim-spin#197

Spin changes: spinframework/spin#2826.

[calebschoepp]

Looking for a few cleanup things but I think this is on the right track!

[kate-goldenring]

@calebschoep CI is failing with:

redis_test.go:165: Failed to create spinapp: admission webhook "vspinapp.kb.io" denied the request: SpinApp.core.spinoperator.dev "test-spintainer-redis" is invalid: spec.executor: Invalid value: "spintainer": executor does not exist in namespace

[calebschoepp]

Thanks for addressing those comments!

No longer relevant

[calebschoepp]

@calebschoep CI is failing with:

redis_test.go:165: Failed to create spinapp: admission webhook "vspinapp.kb.io" denied the request: SpinApp.core.spinoperator.dev "test-spintainer-redis" is invalid: spec.executor: Invalid value: "spintainer": executor does not exist in namespace

I re-ran the test and it passed. Looks like flakiness? Not sure why it would be flaky though b/c we always make sure the executor is set before referencing it.

[michelleN]

lol love the app name

[michelleN]

wonder how we can keep this updated automagically

[kate-goldenring]

maybe we start pushing a latest tag?

[michelleN]

Could we add an e2e for this (or an issue) as a follow up task once shim changes are merged?

[kate-goldenring]

Could we add an e2e for this (or an issue) as a follow up task

@michelleN sure. I'll add that as a follow up and use it as an opportunity to update the image reference to one in the spinkube GHCR

[kate-goldenring]

@michelleN @endocrimes @calebschoepp feel free to merge whenever appropriate. I don't have perms

[kate-goldenring]

@calebschoepp @michelleN @endocrimes I realized i need to add support to Spintainer executor as well but adding the component-id flags to the container args. I'll also follow this up with a draft PR of that because this functionality isn't available in a released version of Spin -- it'll be coming in Spin 3.0. It'll just be the following:

diff --git a/internal/controller/spinapp_controller.go b/internal/controller/spinapp_controller.go
index f3e3ff3..66dbe78 100644
--- a/internal/controller/spinapp_controller.go
+++ b/internal/controller/spinapp_controller.go
@@ -461,10 +461,16 @@ func constructDeployment(ctx context.Context, app *spinv1alpha1.SpinApp, config
 			ReadinessProbe: readinessProbe,
 		}
 	} else if config.SpinImage != nil {
+		components_flag := ""
+		if app.Spec.Components != nil {
+			for _, component := range app.Spec.Components {
+				components_flag = fmt.Sprintf("--component_id=%s", component)
+			}
+		}
 		container = corev1.Container{
 			Name:  app.Name,
 			Image: *config.SpinImage,
-			Args:  []string{"up", "--listen", fmt.Sprintf("0.0.0.0:%d", spinapp.DefaultHTTPPort), "-f", app.Spec.Image, "--runtime-config-file", "/runtime-config.toml"},
+			Args:  []string{"up", "--listen", fmt.Sprintf("0.0.0.0:%d", spinapp.DefaultHTTPPort), "-f", app.Spec.Image, "--runtime-config-file", "/runtime-config.toml", components_flag},
 			Ports: []corev1.ContainerPort{{
 				Name:          spinapp.HTTPPortName,
 				ContainerPort: spinapp.DefaultHTTPPort,

[kate-goldenring]

Added test here: #328