No longer test against MySQL 5.7 #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturner3
requested review from
evan2645,
amartinezfayo,
azdagron and
MarcosDY
as code owners
MySQL 5.7 is EOL as of October 2023. Stop using MySQL 5.7 in integration tests, since it is not easy for the project to support end-of-life database versions. Also log a warning when MySQL 5.7 is used with SPIRE. Importantly, this commit does not remove any existing support for MySQL 5.7. SPIRE may continue to work for some time with MySQL 5.7, but the project makes no compatibility guarantees with MySQL 5.7 anymore, and any existing compatibility with MySQL 5.7 may break at any time without notice. It is recommended that all SPIRE users using MySQL as a SQL backend upgrade to MySQL 8.0. Signed-off-by: Ryan Turner <[email protected]>
rturner3
force-pushed
the
remove-mysql-5.7-testing
branch
from
156feea to
477b75b
Compare
| @@ -61,6 +64,10 @@ func (my mysqlDB) connect(cfg *configuration, isReadOnly bool) (db *gorm.DB, ver | |||
| return nil, "", false, err | |||
| } | |||
|
|
|||
| if version == "5.7" { | |||
There was a problem hiding this comment.
Since we are getting the version running a SELECT VERSION() query, isn't the version string the complete version number, like 5.7.44?
I'm thinking that this should probably check if the version starts with rather than comparing with a complete string.
There was a problem hiding this comment.
Yeah, good catch. I changed the logic to check for the version prefix "5.7." so we can handle any 5.7 versions.
Signed-off-by: Ryan Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 5.7 is EOL as of October 2023.
Stop using MySQL 5.7 in integration tests, since it is not easy for the project to support end-of-life database versions. Also log a warning when MySQL 5.7 is used with SPIRE.
Importantly, this commit does not remove any existing support for MySQL 5.7. SPIRE may continue to work for some time with MySQL 5.7, but the project makes no compatibility guarantees with MySQL 5.7 anymore, and any existing compatibility with MySQL 5.7 may break at any time without notice.
It is recommended that all SPIRE users using MySQL as a SQL backend upgrade to MySQL 8.0.
Closes #4270.