Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for MySQL 5.7 #4270

Closed
rturner3 opened this issue Jun 16, 2023 · 3 comments · Fixed by #5487
Closed

Remove support for MySQL 5.7 #4270

rturner3 opened this issue Jun 16, 2023 · 3 comments · Fixed by #5487
Labels
priority/urgent Issue is approved and is must be completed in the assigned milestone
Milestone

Comments

@rturner3
Copy link
Collaborator

rturner3 commented Jun 16, 2023

Oracle is ending extended support for MySQL 5.7 in October 2023, see page 29 of https://www.oracle.com/us/support/library/lifetime-support-technology-069183.pdf

In general, supporting different versions of databases in the project is challenging, especially when the project wants to use database-native features that may not be available across all supported versions. It is also time consuming to run the unit and integration tests against each version of databases, and this results in longer PR CI build times (currently 5-10 minutes per database version).

Furthermore, SPIRE now supports arm64 architecture, but MySQL 5.7 does not, and presumably it never will since it's rapidly approaching EOL. This currently prevents us from running the MySQL 5.7 integration tests for SPIRE on arm64 architecture.

Starting in November 2023, we should strongly consider removing support for MySQL 5.7. This includes some production code that works around the lack of support for common table expressions in MySQL 5.7 as well as testing against MySQL 5.7 in the integration tests.

While the project doesn't yet publish an official matrix of supported database versions (see #3711), today this is largely implied by the versions that are tested in the repository.

@rturner3 rturner3 added the triage/in-progress Issue triage is in progress label Jun 16, 2023
@edwbuck
Copy link
Contributor

edwbuck commented Jun 20, 2023

Per team discussion, we should couple the removal of testing support with the removal of 5.7 specific support code.

@rturner3 rturner3 changed the title Remove testing support for MySQL 5.7 Remove support for MySQL 5.7 Jun 20, 2023
@rturner3 rturner3 added priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels Jun 20, 2023
Copy link

This issue is stale because it has been open for 365 days with no activity.

@github-actions github-actions bot added the stale label Jun 19, 2024
@azdagron azdagron added this to the 1.11.0 milestone Jun 19, 2024
@azdagron azdagron added priority/urgent Issue is approved and is must be completed in the assigned milestone and removed priority/backlog Issue is approved and in the backlog stale labels Jun 19, 2024
@azdagron
Copy link
Member

This could have gone out in 1.10.0 but we missed the window. Reprioritized urgent for 1.11.0 so that we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/urgent Issue is approved and is must be completed in the assigned milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants