Skip to content

Return an error when having an expired SVID when rotating the agent SVID #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amartinezfayo merged 2 commits into from
Jan 25, 2021
Merged

Return an error when having an expired SVID when rotating the agent SVID #2065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106c908
Return an error when having an expired SVID when rotating the agent SVID
amartinezfayo Jan 21, 2021
ce17b36
Merge branch 'master' into agent-expired-shutdown
Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/agent/svid/rotator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ func (r *rotator) runRotation(ctx context.Context) error {
err := r.rotateSVID(ctx)

switch {
case err != nil && rotationutil.X509Expired(r.clk.Now(), r.state.Value().(State).SVID[0]):
r.c.Log.WithError(err).Error("Could not rotate agent SVID")
// Since our X509 cert has expired, and we weren't able to carry out a rotation request, we're probably unrecoverable without re-attesting.
return fmt.Errorf("current SVID has already expired and rotation failed: %v", err)
case err != nil && nodeutil.ShouldAgentReattest(err):
r.c.Log.WithError(err).Error("Could not rotate agent SVID")
return err
Expand Down