Return an error when having an expired SVID when rotating the agent SVID#2065
Merged
amartinezfayo merged 2 commits intospiffe:masterfrom Jan 25, 2021
Merged
Conversation
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
APTy,
azdagron,
evan2645 and
rturner3
as code owners
azdagron
pushed a commit
to azdagron/spire
that referenced
this pull request
Mar 30, 2021
…VID (spiffe#2065) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents should shutdown when having an expired SVID during agent SVID rotation.
The current behavior continues trying to rotate using an expired SVID, which will never succeed without going through re-attestation.
This is a regression introduced in v0.12.0. Previous versions would shutdown properly.
Fixes #2061.