Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tainted field to upstream authority messages #39

Merged
merged 5 commits into from
May 2, 2023
Merged

Add tainted field to upstream authority messages #39

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5009e0
Add tainted bool
MarcosDY Oct 25, 2022
bc7a13f
Add status to JWT key
MarcosDY Nov 28, 2022
fc80556
Revert
MarcosDY Feb 20, 2023
014c987
PR changes
MarcosDY Feb 22, 2023
0e7a9a3
Merge branch 'next' into update-uptream-authority
MarcosDY Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions proto/spire/plugin/types/jwtkey.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions proto/spire/plugin/types/jwtkey.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ message JWTKey {
// When the key expires (seconds since Unix epoch). If zero, the key does
// not expire.
int64 expires_at = 3;

// This key is no longer secure and must not be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This key is no longer secure and must not be used
// Indicates if the key has been tainted. A tainted key is not safe to be used anymore.

bool tainted = 4;
}
23 changes: 17 additions & 6 deletions proto/spire/plugin/types/x509certificate.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions proto/spire/plugin/types/x509certificate.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@ option go_package = "github.com/spiffe/spire-plugin-sdk/proto/spire/plugin/types
message X509Certificate {
// The ASN.1 DER encoded bytes of the X.509 certificate.
bytes asn1 = 1;

// This authority is no longer secure and must not be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This authority is no longer secure and must not be used
// Indicates if the authority has been tainted. A tainted authority is not safe to be used anymore.

bool tainted = 2;
}