Add tainted field to upstream authority messages #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <[email protected]>
Signed-off-by: Marcos Yacob <[email protected]>
Signed-off-by: Marcos Yacob <[email protected]>
MarcosDY
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
| @@ -12,4 +12,7 @@ message JWTKey { | |||
| // When the key expires (seconds since Unix epoch). If zero, the key does | |||
| // not expire. | |||
| int64 expires_at = 3; | |||
|
|
|||
| // This key is no longer secure and must not be used | |||
There was a problem hiding this comment.
Suggested change
| // This key is no longer secure and must not be used | |
| // Indicates if the key has been tainted. A tainted key is not safe to be used anymore. |
| @@ -5,4 +5,7 @@ option go_package = "github.com/spiffe/spire-plugin-sdk/proto/spire/plugin/types | |||
| message X509Certificate { | |||
| // The ASN.1 DER encoded bytes of the X.509 certificate. | |||
| bytes asn1 = 1; | |||
|
|
|||
| // This authority is no longer secure and must not be used | |||
There was a problem hiding this comment.
Suggested change
| // This authority is no longer secure and must not be used | |
| // Indicates if the authority has been tainted. A tainted authority is not safe to be used anymore. |
Signed-off-by: Marcos Yacob <[email protected]>
evan2645
approved these changes
Mar 7, 2023
MarcosDY
added a commit
that referenced
this pull request
Sep 10, 2024
* Add tainted propagation to upstream authorities. Signed-off-by: Marcos Yacob <[email protected]>
MarcosDY
added a commit
that referenced
this pull request
Sep 10, 2024
* Add tainted propagation to upstream authorities. Signed-off-by: Marcos Yacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update messages used on upstream authority plugins to propagate tainted keys
Fixes: spiffe/spire#3886