dialect with interval style #11
Merged
+256
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Phillip LeBlanc <[email protected]>
phillipleblanc
approved these changes
Jul 15, 2024
phillipleblanc
added a commit
that referenced
this pull request
Jul 15, 2024
* wip * add interval style * format * Apply suggestions from code review Co-authored-by: Phillip LeBlanc <[email protected]> * move all intervel test together --------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
y-f-u
added a commit
that referenced
this pull request
Jul 15, 2024
--------- Co-authored-by: Phillip LeBlanc <[email protected]>
sgrebnov
pushed a commit
that referenced
this pull request
Jul 16, 2024
… `interval` (apache#11466) * Unparser rule for datatime cast (#10) * use timestamp as the identifier for date64 * rename * implement CustomDialectBuilder * fix * dialect with interval style (#11) --------- Co-authored-by: Phillip LeBlanc <[email protected]> * fmt * clippy * doc * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Andrew Lamb <[email protected]> * update the doc for CustomDialectBuilder * fix doc test --------- Co-authored-by: Phillip LeBlanc <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interval style for dialect.
Keep dialect to be simple as a few toggles, and unparsing logic sit within
expr