Skip to content

Conversation

@y-f-u
Copy link

@y-f-u y-f-u commented Jul 11, 2024

this allow custom dialect to configure which identifier for unparsing date64: datetime or timestamp

@y-f-u
Copy link
Author

y-f-u commented Jul 11, 2024

reopen this pull request to squash merge rather than merge.

@y-f-u y-f-u merged commit 068057d into spiceai-39 Jul 11, 2024
@phillipleblanc phillipleblanc deleted the unparser-rule-for-datatime-cast branch July 14, 2024 22:58
phillipleblanc pushed a commit that referenced this pull request Jul 15, 2024
* use timestamp as the identifier for date64

* rename

* implement CustomDialectBuilder

* fix
y-f-u added a commit that referenced this pull request Jul 15, 2024
* use timestamp as the identifier for date64

* rename

* implement CustomDialectBuilder

* fix
sgrebnov pushed a commit that referenced this pull request Jul 16, 2024
… `interval` (apache#11466)

* Unparser rule for datatime cast (#10)

* use timestamp as the identifier for date64

* rename

* implement CustomDialectBuilder

* fix

* dialect with interval style (#11)

---------

Co-authored-by: Phillip LeBlanc <[email protected]>

* fmt

* clippy

* doc

* Update datafusion/sql/src/unparser/expr.rs

Co-authored-by: Andrew Lamb <[email protected]>

* update the doc for CustomDialectBuilder

* fix doc test

---------

Co-authored-by: Phillip LeBlanc <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant