Skip to content

Ensure rendered exceptions take up minimal space #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patriksvensson merged 2 commits into from
Apr 15, 2026
Merged

Ensure rendered exceptions take up minimal space #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317d222
Make exceptions easier to test
patriksvensson Apr 15, 2026
9f98435
Ensure rendered exceptions take up minimal space
patriksvensson Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Spectre.Console.Tests/Expectations/Exception/CallSite.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
System.InvalidOperationException: Something threw!
System.InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.GenericMethodThatThrows<T0,T1,TRet>(int? number) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithGenericInnerException() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithGenericInnerException() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exceptions_With_Generic_Type_Parameters_In_Callsite_As_Expected>b__4_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
System.InvalidOperationException: Something threw!
System.InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.GenericMethodThatThrows<T0,T1,TRet>(int? number) in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithGenericInnerException() in /xyz/Exceptions.cs:200
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithGenericInnerException() in /xyz/Exceptions.cs:300
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exceptions_With_Generic_Type_Parameters_In_Callsite_As_Expected>b__4_0() in /xyz/ExceptionTests.cs:400
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:500
6 changes: 3 additions & 3 deletions src/Spectre.Console.Tests/Expectations/Exception/Default.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
System.InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception>b__0_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception>b__0_0() in /xyz/ExceptionTests.cs:200
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:300
6 changes: 6 additions & 0 deletions src/Spectre.Console.Tests/Expectations/Exception/Expanded_Panel.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ GenericException<IAnsiConsole>: Throwing! │
│ at bool MethodThatThrowsGenericException<T>() in Exceptions.cs:100 │
│ at void <Exception_Within_Expanded_Panel_Should_Expand_As_Expected>b__10_0() in ExceptionTests.cs:200 │
│ at Exception GetException(Action action) in ExceptionTests.cs:300 │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
6 changes: 3 additions & 3 deletions ...ests/Expectations/Exception/GenericException.Output_exceptionFormats=Default.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Spectre.Console.Tests.Data.GenericException<Spectre.Console.IAnsiConsole>: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:200
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:300
6 changes: 3 additions & 3 deletions ...tations/Exception/GenericException.Output_exceptionFormats=ShortenEverything.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GenericException<IAnsiConsole>: Throwing!
at bool MethodThatThrowsGenericException<T>() in /xyz/ in Exceptions.cs:nn
at void <Should_Write_GenericException>b__8_0() in /xyz/ in ExceptionTests.cs:nn
at Exception GetException(Action action) in /xyz/ in ExceptionTests.cs:nn
at bool MethodThatThrowsGenericException<T>() in Exceptions.cs:100
at void <Should_Write_GenericException>b__8_0() in ExceptionTests.cs:200
at Exception GetException(Action action) in ExceptionTests.cs:300
6 changes: 3 additions & 3 deletions ...pectations/Exception/GenericException.Output_exceptionFormats=ShortenMethods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Spectre.Console.Tests.Data.GenericException<Spectre.Console.IAnsiConsole>: Throwing!
at bool MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:nn
at void <Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:nn
at Exception GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:100
at void <Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:200
at Exception GetException(Action action) in /xyz/ExceptionTests.cs:300
6 changes: 3 additions & 3 deletions ...Expectations/Exception/GenericException.Output_exceptionFormats=ShortenTypes.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GenericException<IAnsiConsole>: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrowsGenericException<T>() in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_GenericException>b__8_0() in /xyz/ExceptionTests.cs:200
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:300
14 changes: 7 additions & 7 deletions src/Spectre.Console.Tests/Expectations/Exception/InnerException.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
System.InvalidOperationException: Something threw!
System.InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Inner_Exception>b__3_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
System.InvalidOperationException: Something threw!
System.InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:200
at void Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:300
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Inner_Exception>b__3_0() in /xyz/ExceptionTests.cs:400
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:500
6 changes: 6 additions & 0 deletions src/Spectre.Console.Tests/Expectations/Exception/MinimumSpace.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
┌────────────────────────────────────────────────────────────────────────────────────────┐
│ GenericException<IAnsiConsole>: Throwing! │
│ at bool MethodThatThrowsGenericException<T>() in Exceptions.cs:100 │
│ at void <Should_Take_Up_Minimum_Space_When_Wrapped>b__9_0() in ExceptionTests.cs:200 │
│ at Exception GetException(Action action) in ExceptionTests.cs:300 │
└────────────────────────────────────────────────────────────────────────────────────────┘
6 changes: 3 additions & 3 deletions src/Spectre.Console.Tests/Expectations/Exception/OutParam.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
InvalidOperationException: Throwing!
at List<T> Spectre.Console.Tests.Data.TestExceptions.GenericMethodWithOutThatThrows<T>(out List<T> firstFewItems) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Output_Param>b__5_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
at List<T> Spectre.Console.Tests.Data.TestExceptions.GenericMethodWithOutThatThrows<T>(out List<T> firstFewItems) in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Output_Param>b__5_0() in /xyz/ExceptionTests.cs:200
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:300
6 changes: 3 additions & 3 deletions src/Spectre.Console.Tests/Expectations/Exception/ShortenedMethods.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
System.InvalidOperationException: Throwing!
at bool MethodThatThrows(int? number) in /xyz/Exceptions.cs:nn
at void <Should_Write_Exception_With_Shortened_Methods>b__2_0() in /xyz/ExceptionTests.cs:nn
at Exception GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool MethodThatThrows(int? number) in /xyz/Exceptions.cs:100
at void <Should_Write_Exception_With_Shortened_Methods>b__2_0() in /xyz/ExceptionTests.cs:200
at Exception GetException(Action action) in /xyz/ExceptionTests.cs:300
6 changes: 3 additions & 3 deletions src/Spectre.Console.Tests/Expectations/Exception/ShortenedTypes.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Shortened_Types>b__1_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:100
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Shortened_Types>b__1_0() in /xyz/ExceptionTests.cs:200
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:300
10 changes: 5 additions & 5 deletions src/Spectre.Console.Tests/Expectations/Exception/Tuple.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:nn
at (string Key, List<T> Values) Spectre.Console.Tests.Data.TestExceptions.GetTuplesWithInnerException<T>((int First, string Second) myValue) in /xyz/Exceptions.cs:nn
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Tuple_Return>b__6_0() in /xyz/ExceptionTests.cs:nn
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
InvalidOperationException: Throwing!
at bool Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(int? number) in /xyz/Exceptions.cs:100
at (string Key, List<T> Values) Spectre.Console.Tests.Data.TestExceptions.GetTuplesWithInnerException<T>((int First, string Second) myValue) in /xyz/Exceptions.cs:200
at void Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Tuple_Return>b__6_0() in /xyz/ExceptionTests.cs:300
at Exception Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:400
17 changes: 15 additions & 2 deletions src/Spectre.Console.Tests/Expectations/Public_API.Output.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1897,11 +1897,24 @@
ShortenEverything = 7,
NoStackTrace = 16,
}
[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("AssemblyLoadTrimming", "IL2026:RequiresUnreferencedCode")]
[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("AssemblyLoadTrimming", "IL2070:RequiresUnreferencedCode")]
[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("AssemblyLoadTrimming", "IL2075:RequiresUnreferencedCode")]
[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("AssemblyLoadTrimming", "IL3050:RequiresUnreferencedCode")]
public class ExceptionInfoResolver
{
public ExceptionInfoResolver() { }
public virtual int GetFileLineNumber(System.Diagnostics.StackFrame frame) { }
public virtual string? GetFileName(System.Diagnostics.StackFrame frame) { }
public virtual string GetMethodName(System.Reflection.MethodBase method) { }
public virtual string GetParameterName(System.Reflection.ParameterInfo parameter) { }
}
public sealed class ExceptionSettings
{
public ExceptionSettings() { }
public Spectre.Console.ExceptionFormats Format { get; set; }
public Spectre.Console.ExceptionStyle Style { get; set; }
public Spectre.Console.ExceptionFormats Format { get; init; }
public Spectre.Console.ExceptionInfoResolver Resolver { get; init; }
public Spectre.Console.ExceptionStyle Style { get; init; }
}
public sealed class ExceptionStyle
{
Expand Down
Loading