Skip to content

Ensure rendered exceptions take up minimal space#2089

Merged
patriksvensson merged 2 commits intospectreconsole:mainfrom
patriksvensson:feature/GH-1844
Apr 15, 2026
Merged

Ensure rendered exceptions take up minimal space#2089
patriksvensson merged 2 commits intospectreconsole:mainfrom
patriksvensson:feature/GH-1844

Conversation

@patriksvensson
Copy link
Copy Markdown
Contributor

@patriksvensson patriksvensson commented Apr 15, 2026

Fixes #1844

  • I have read the Contribution Guidelines
  • I have checked that there isn't already another pull request that solves the above issue
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors

Changes

The generated renderable that contains the exception information was set to expand to the maximum terminal area. This pull request changes the behavior to instead use as little space as possible.

Also made exceptions easier to test by adding an ExceptionInfoResolver that gets the
exception information used when rendering an exception. This way, we do not have to
do manual exception scrubbing of the output (that messes up rendering).


Please upvote 👍 this pull request if you are interested in it.

@patriksvensson patriksvensson requested review from a team and 0xced and removed request for 0xced April 15, 2026 22:52
@patriksvensson patriksvensson merged commit 5abb97d into spectreconsole:main Apr 15, 2026
3 checks passed
@patriksvensson patriksvensson deleted the feature/GH-1844 branch April 15, 2026 23:04
This was referenced Apr 16, 2026
This was referenced Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExceptionExtensions.GetRenderable() stretches panels and tables

1 participant