Add config option to enable/disable unique token #212
Conversation
| /* | ||
| * Should a unique token be added to the route name | ||
| */ | ||
| 'add_unique_token_to_route_name' => false, |
There was a problem hiding this comment.
@it-can Just personal preference but I would probably simplify this to 'tokenize_route_name'.
There was a problem hiding this comment.
i think @freekmurze should decide on this one
There was a problem hiding this comment.
Although tokenize_route_name would be good I thinkadd_unique_token_to_route_name is more clear / human.
|
|
||
| $configName = Str::before($routeNameSuffix, '.'); | ||
| if (config('webhook-client.add_unique_token_to_route_name', false)) { |
There was a problem hiding this comment.
@it-can I think this should probably default to true since the shared route names already break route caching and there is a documented feature that causes that scenario. I can definitely see the benefit of calling the routes by name but route naming is more of an underlying structure of the package and not a documented feature.
There was a problem hiding this comment.
@freekmurze can decide on this one too...
There was a problem hiding this comment.
I think it should be set to false for now, so we don't break stuff for existing users.
For a next major version, I'll consider setting it to true by default.
|
Thanks! |
Fix for #210