Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unique token to route names #210

Merged

Conversation

ryanlholt
Copy link
Contributor

Closes #209

@freekmurze freekmurze merged commit 6ed76b0 into spatie:main Apr 24, 2024
16 checks passed
@freekmurze
Copy link
Member

Thanks!

@ryanlholt ryanlholt deleted the bug/route-cache-fails-when-config-shared branch April 24, 2024 14:48
@ryanlholt
Copy link
Contributor Author

Thank you!

@it-can
Copy link
Contributor

it-can commented Apr 25, 2024

This bit me in the *** today... is there a way to disable this? Had to revert to 3.3.0 to have it working again...

Symfony\Component\Routing\Exception\RouteNotFou... ·POST /checkout/payment
Route [webhook-client-mollie] not defined.

@freekmurze
Copy link
Member

@ryanlholt seems like this behaviour can be breaking. Could you introduce a config value to enable this behaviour?

@it-can
Copy link
Contributor

it-can commented Apr 25, 2024

this is a problem when using the webhook routes like this:

route('webhook-client-mollie')

in version 3.3.1 the route seems to be:

route('webhook-client-molliejsMQhWja')

@ryanlholt
Copy link
Contributor Author

@freekmurze I certainly can but it looks like @it-can has an open PR that only needs a slight change to work. Should we default the config value to true since the non-tokenized routes were already breaking documented functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route caching fails when multiple routes use same configuration
3 participants