Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Un-ignore numpy warnings from scipy-dev #2374

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 15, 2023

because they fixed it while I was sleeping

Description

Reverts 2 out of 3 from #2369

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Aug 15, 2023
@pllim pllim added this to the 3.6.2 milestone Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f578d7) 90.61% compared to head (5185b29) 90.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         159      159           
  Lines       18177    18177           
=======================================
  Hits        16471    16471           
  Misses       1706     1706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim

This comment was marked as resolved.

because they fixed it while I was sleeping
@pllim pllim marked this pull request as ready for review August 19, 2023 00:57
@pllim pllim merged commit d067429 into spacetelescope:main Aug 19, 2023
14 checks passed
@pllim pllim deleted the revert-scipy-warn-ignore branch August 19, 2023 00:58
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Aug 19, 2023
pllim added a commit that referenced this pull request Aug 19, 2023
…4-on-v3.6.x

Backport PR #2374 on branch v3.6.x (TST: Un-ignore numpy warnings from scipy-dev)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant