Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Ignore array_api experimental warning when scipy-dev imports numpy-dev #2369

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 14, 2023

Description

This pull request is to ignore the warning reported upstream to:

The dask one is already fixed on their main branch, but I don't want to pull in dev dask for our test suite. We don't use it directly.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Aug 14, 2023
@pllim pllim added this to the 3.6.2 milestone Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7dcc714) 90.72% compared to head (22386a9) 90.72%.

❗ Current head 22386a9 differs from pull request most recent head fc149bb. Consider uploading reports for the commit fc149bb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         157      157           
  Lines       18015    18015           
=======================================
  Hits        16345    16345           
  Misses       1670     1670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim

This comment was marked as resolved.

@pllim
Copy link
Contributor Author

pllim commented Aug 14, 2023

Ah, nvm. Local install somehow downgraded numpy (looking at you, bqplot). If I force numpy dev to install again, I can see it.

when scipy-dev imports numpy-dev

TST: Ignore numpy.distutils DeprecationWarning
from scipy import of numpy-dev

TST: Ignore DeprecationWarning from dask
@pllim pllim force-pushed the fix-devdeps-again-2023-08-14 branch from 22386a9 to fc149bb Compare August 14, 2023 20:37
@pllim pllim marked this pull request as ready for review August 14, 2023 20:59
@pllim
Copy link
Contributor Author

pllim commented Aug 14, 2023

Just gonna YOLO this one. Doesn't need a review.

@pllim pllim merged commit 058ea12 into spacetelescope:main Aug 14, 2023
14 checks passed
@pllim pllim deleted the fix-devdeps-again-2023-08-14 branch August 14, 2023 21:00
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Aug 14, 2023
pllim added a commit that referenced this pull request Aug 14, 2023
…9-on-v3.6.x

Backport PR #2369 on branch v3.6.x (TST: Ignore array_api experimental warning when scipy-dev imports numpy-dev)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant