Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conda-forge, bioconda; Updated Python version to 3.7 #677

Merged
merged 4 commits into from
May 21, 2019

Conversation

dsouzadaniel
Copy link
Contributor

This code fixes Issue : #642

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   89.26%   89.26%           
=======================================
  Files          27       27           
  Lines        4238     4238           
  Branches       39       39           
=======================================
  Hits         3783     3783           
  Misses        455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce8cda...f430738. Read the comment docs.

@luizirber luizirber merged commit ab0279a into sourmash-bio:master May 21, 2019
@luizirber
Copy link
Member

Thanks @dsouzadaniel ! Can you please set up an ORCID ID and post here? This way we can credit you =]

@luizirber
Copy link
Member

Hi again @dsouzadaniel!

We're gearing up for the sourmash 3.0 paper on JOSS, so...

Can you please set up an ORCID ID and post here? This way we can credit you =]

do you have an ORCID ID? =]

(I'm adding all contributors to codemeta.json in #837)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants