-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ephemeral storage to match cache #2953
Conversation
Could @sourcegraph/search-core take a look at this to see if this resource reduction is ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL ephemeral-storage
limits! Finally! I see there is a whole bunch of stuff related to ephemeral-storage in k8s now, not just emptyDir
. Would love to use GenericEphemeralVolume
so we can get rid of the dir watcher daemonset stuff. I see that it is behind a feature flag though :(
@@ -30,7 +30,7 @@ spec: | |||
- name: searcher | |||
env: | |||
- name: SEARCHER_CACHE_SIZE_MB | |||
value: "100000" | |||
value: "50000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe we should avoid duplication here, and instead use something like
valueFrom:
fieldRef:
fieldPath: spec.resources.requests.ephemeral-storage
That will require us updating the cache parsing code to understand kubernetes resource limit specifications, but that would be a good thing. Not for this PR, but what do you think?
Thanks for this, I had to adjust this for a customer but never got back around to fixing the root cause. |
I was incorrect with my first attempt at this. This requires using |
7165b69
to
e63fb0d
Compare
Update CHANGELOG for ephemeral storage change [#2953](sourcegraph/deploy-sourcegraph#2953)
Related to #2369
Fixes https://github.com/sourcegraph/sourcegraph/issues/20869
If these values differ, the pod will be evicted for exceeding its storage allotment
Checklist