Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match cache size to request #2369

Merged
merged 6 commits into from
May 6, 2021
Merged

match cache size to request #2369

merged 6 commits into from
May 6, 2021

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Apr 9, 2021

We should match the size of the cache to the default request for ephemeral storage.

@davejrt davejrt requested review from pecigonzalo and a team April 9, 2021 16:29
daxmc99
daxmc99 reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally prefer we raise the requests to this value. Decreasing it may have unintended consequences

@davejrt davejrt force-pushed the dt/adjust_limits branch from f8ccda3 to 7aaec23 Compare May 5, 2021 17:12
@davejrt
Copy link
Contributor Author

davejrt commented May 5, 2021

@daxmc99 I've increased the requests and limits. Do you off hand know if having the request/limit set to the same value would result in this always being evicted? I suspect we should allow some some burst right?

@davejrt davejrt requested review from daxmc99 and removed request for pecigonzalo May 5, 2021 17:29
daxmc99
daxmc99 suggested changes May 5, 2021
View reviewed changes
Copy link
Contributor

@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes the most sense.
This will make 10GB a requirement to schedule the pod though.
The pod will only be evicted if it reaches 12 GB
We should document this in the changelog

base/symbols/symbols.Deployment.yaml Outdated Show resolved Hide resolved
base/symbols/symbols.Deployment.yaml Outdated Show resolved Hide resolved
@davejrt davejrt enabled auto-merge (squash) May 6, 2021 15:43
@davejrt davejrt merged commit 26ef234 into master May 6, 2021
@davejrt davejrt deleted the dt/adjust_limits branch May 6, 2021 15:58
@daxmc99 daxmc99 mentioned this pull request May 11, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxmc99 daxmc99 daxmc99 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davejrt @daxmc99