BugFix: Issue#9 download button not working #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Documentation Fix: Create the bare minimums (#12) * Created the readme file * Update issue templates Added the default GH templates for bug reports and features * Added PR templates * Workaround for GH problem: wont pick multiple PR templates * Removing workaround to test alternate GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters] * Updated PR templates to remove front matter headings * Publishing readme content * Fixed minor markdown defects * Minor content edits * Fixes done (#14)
soumik-mukherjee
added a commit
that referenced
this pull request
Apr 16, 2020
* Documentation Fix: Create the bare minimums (#12) * Created the readme file * Update issue templates Added the default GH templates for bug reports and features * Added PR templates * Workaround for GH problem: wont pick multiple PR templates * Removing workaround to test alternate GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters] * Updated PR templates to remove front matter headings * Publishing readme content * Fixed minor markdown defects * Minor content edits * Fixes done (#14) * BugFix: Issue#9 download button not working (#16) * Upstream merge for WIP bug branch (#15) * Documentation Fix: Create the bare minimums (#12) * Created the readme file * Update issue templates Added the default GH templates for bug reports and features * Added PR templates * Workaround for GH problem: wont pick multiple PR templates * Removing workaround to test alternate GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters] * Updated PR templates to remove front matter headings * Publishing readme content * Fixed minor markdown defects * Minor content edits * Fixes done (#14) * Added new Link comp and associated changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Describe the changes proposed
Currently a polymorphic form of the
FaIconButton, is being used, for the implementation ofDownloadbutton. This adds htmlaelement's attributes to turn an otherwise normal button to a link.This change moves logic for a link to its own component and no polymorphic forms of
FaIconButtonare used. The substantial changes areFaIconLinkbutton.stories.jsRecorderControlto use the new component insteadUser Guide
Steps for users to use any new behavior, if applicable.
None
Expected behavior
Clicking on
Downloadbutton at the end of a recording should open up the file save dialogScreenshots
NA. But this was tested.
Additional context
None
@soumik-mukherjee