Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Fix: Create the bare minimums #12

Merged
merged 9 commits into from
Apr 15, 2020

Conversation

soumik-mukherjee
Copy link
Owner

Resolves #10

Describe the changes proposed
Changes proposed in this feature PR

  • Added a repo level readme file with content per linked issue
  • Added templates for issues (GH default)
  • Added templates for PRs (custom)

User Guide
Steps for users to use the new behavior:
For issues, nothing needs to be done differently than the GH workflow. PR not so lucky, GH doesn't seem to support multiple templates. Follow steps below to use a template with a PR.

Using templates with a PR

  1. Use the default GH workflow to create a PR, and get to the step of Comparing changes
  2. Once there, append the template name as a query parameter in the browser address bar
  3. The following templates are available, URL query parameters are shown alongwith
    • For a PR proposing code changes to deliver a feature - use ?template=feature_changes.md
    • For a PR proposing code changes to deliver a bug fix- use ?template=bugfix_changes.md
    • For a PR to just pull in changes from others (i.e. via upstream) - use ?template=upstream_merge.md
  4. Finally, click on the Create Pull Request button

Expected behavior
A clear and concise description of what you expected to happen.
Issues will use the templates per the type selection while raising them.
For PRs, the above steps if followed will open the new PR form with the template pre-populated in the Write tab. Contributors still need to fill up the template though before submitting (same as with issues)

Screenshots
If applicable, add screenshots to evidence testing of the behaviour this change.
N/A

Additional context
Add any other context about the change here.

@soumik-mukherjee

soumik-mukherjee and others added 6 commits April 15, 2020 14:31
Added the default GH templates for bug reports and features
GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters]
@soumik-mukherjee soumik-mukherjee added the documentation Improvements or additions to documentation label Apr 15, 2020
@soumik-mukherjee soumik-mukherjee added this to the Sprint 1 milestone Apr 15, 2020
@soumik-mukherjee soumik-mukherjee self-assigned this Apr 15, 2020
@soumik-mukherjee soumik-mukherjee merged commit 73210b9 into master Apr 15, 2020
@soumik-mukherjee soumik-mukherjee deleted the docs/10_add_basic_documentation branch April 15, 2020 16:05
soumik-mukherjee added a commit that referenced this pull request Apr 16, 2020
* Documentation Fix: Create the bare minimums (#12)

* Created the readme file

* Update issue templates

Added the default GH templates for bug reports and features

* Added PR templates

* Workaround for GH problem: wont pick multiple PR templates

* Removing workaround to test alternate

GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters]

* Updated PR templates to remove front matter headings

* Publishing readme content

* Fixed minor markdown defects

* Minor content edits

* Fixes done (#14)
soumik-mukherjee added a commit that referenced this pull request Apr 16, 2020
* Upstream merge for WIP bug branch (#15)

* Documentation Fix: Create the bare minimums (#12)

* Created the readme file

* Update issue templates

Added the default GH templates for bug reports and features

* Added PR templates

* Workaround for GH problem: wont pick multiple PR templates

* Removing workaround to test alternate

GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters]

* Updated PR templates to remove front matter headings

* Publishing readme content

* Fixed minor markdown defects

* Minor content edits

* Fixes done (#14)

* Added new Link comp and associated changes
soumik-mukherjee added a commit that referenced this pull request Apr 16, 2020
* Documentation Fix: Create the bare minimums (#12)

* Created the readme file

* Update issue templates

Added the default GH templates for bug reports and features

* Added PR templates

* Workaround for GH problem: wont pick multiple PR templates

* Removing workaround to test alternate

GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters]

* Updated PR templates to remove front matter headings

* Publishing readme content

* Fixed minor markdown defects

* Minor content edits

* Fixes done (#14)

* BugFix: Issue#9 download button not working (#16)

* Upstream merge for WIP bug branch (#15)

* Documentation Fix: Create the bare minimums (#12)

* Created the readme file

* Update issue templates

Added the default GH templates for bug reports and features

* Added PR templates

* Workaround for GH problem: wont pick multiple PR templates

* Removing workaround to test alternate

GH does not seem to pickup multiple PR templates. This file was added temporarily to validate this issue (indeed it doesn't and by default only picks up `.github/pull_request_template.md`). Looks like the only way to get multiple templates working is by using URL query parameters as discussed (here)[https://help.github.com/en/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters]

* Updated PR templates to remove front matter headings

* Publishing readme content

* Fixed minor markdown defects

* Minor content edits

* Fixes done (#14)

* Added new Link comp and associated changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic documentation
1 participant