Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netlink] refill netlink cache when failing to get the link object by name #506

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[netlink] refill netlink cache when failing to get the link object by name #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion common/linkcache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,13 @@ string LinkCache::ifindexToName(int ifindex)

struct rtnl_link* LinkCache::getLinkByName(const char *name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLinkByName

The change looks good to me. I am wondering how is this function used in application? I could not find any use cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLinkByName

The change looks good to me. I am wondering how is this function used in application? I could not find any use cases.

Hi qiluo
Yes, the function is not yet used in the code. I use it when trying to do the optimization of VLAN interface creation through netlink.

{
return rtnl_link_get_by_name(m_link_cache, name);
struct rtnl_link* link = NULL;
link = rtnl_link_get_by_name(m_link_cache, name);
if(NULL == link)
{
/* Trying to refill cache */
nl_cache_refill(m_nl_sock ,m_link_cache);
link = rtnl_link_get_by_name(m_link_cache, name);
}
return link;
}