[netlink] refill netlink cache when failing to get the link object by name #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name. Signed-off-by: wangshengjun <[email protected]>
|
@qiluo-msft Could you please review this PR? |
qiluo-msft
changed the title
qiluo-msft
reviewed
Jul 28, 2021
| @@ -77,5 +77,13 @@ string LinkCache::ifindexToName(int ifindex) | |||
|
|
|||
| struct rtnl_link* LinkCache::getLinkByName(const char *name) | |||
There was a problem hiding this comment.
getLinkByName
The change looks good to me. I am wondering how is this function used in application? I could not find any use cases.
Hi qiluo
Yes, the function is not yet used in the code. I use it when trying to do the optimization of VLAN interface creation through netlink.
qiluo-msft
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The getLinkByName may fail because of the outdated netlink cache
How I did it
Refill the netlink cache when we fail to get link object.
How to verify it
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)