[test gap] Test gap to cover advertising through network command in BGP #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the TOR properly.
|
@dgsudharsan for viz |
|
@siqbal1986 , can you please provide description on the steps and expected result? Initially i thought its a T1 test but your test topology mentions t0 and vs. |
|
@prsunny I have updated the Description. |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…the TOR (sonic-net#14683) Description of PR Summary: Fixes # (issue) sonic-net#10837 Orignal Problem In multipath scenario when a route is advertised through network command from two neighbors, only one path is chosen. Doing clear bgp * recovers the device from this scenario. If the same route (be it default or non-default) is advertised from two leaf to a ToR, the leaf initially shows only one leaf's links as next hop. When we do clear bgp *, it is then updated. B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:16:52 via 192.168.2.2, PortChannel2, weight 1, 00:16:52 via 192.168.3.2, PortChannel3, weight 1, 00:16:52 via 192.168.4.2, PortChannel4, weight 1, 00:16:52 After doing clear bgp * in tgn-sonic-n2-t1 I can see this B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:00:02 via 192.168.2.2, PortChannel2, weight 1, 00:00:02 via 192.168.3.2, PortChannel3, weight 1, 00:00:02 via 192.168.4.2, PortChannel4, weight 1, 00:00:02 via 192.168.5.2, PortChannel5, weight 1, 00:00:02 via 192.168.6.2, PortChannel6, weight 1, 00:00:02 via 192.168.8.2, PortChannel8, weight 1, 00:00:02 This issue was fixed in PR sonic-net/sonic-buildimage#17184 However a test for this was missing. so this test adds a prefix on 2 T1 neighbors using network command and checks if the advertised route is learnt on the T0 DUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
#10837
Orignal Problem
In multipath scenario when a route is advertised through network command from two neighbors, only one path is chosen. Doing clear bgp * recovers the device from this scenario.
If the same route (be it default or non-default) is advertised from two leaf to a ToR, the leaf initially shows only one leaf's links as next hop. When we do clear bgp *, it is then updated.
This issue was fixed in PR sonic-net/sonic-buildimage#17184
However a test for this was missing.
so this test adds a prefix on 2 T1 neighbors using network command and checks if the advertised route is learnt on the T0 DUT
Type of change
Added anew test
Back port request
Approach
What is the motivation for this PR?
advertising through network command might result in issue sonic-net/sonic-buildimage#17183.
How did you do it?
Add same route on 2 T1 neighbors of a TOR and advertise them. Then check on the DUT the routes are learnt and added to ROUTE_TABLE.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
T0 and Vs
Documentation