-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test gap] Test gap to cover advertising through network command in BGP #10837
Comments
Merged
11 tasks
This was referenced Aug 2, 2024
8 tasks
StormLiangMS
pushed a commit
that referenced
this issue
Oct 23, 2024
…the TOR (#14683) Description of PR Summary: Fixes # (issue) #10837 Orignal Problem In multipath scenario when a route is advertised through network command from two neighbors, only one path is chosen. Doing clear bgp * recovers the device from this scenario. If the same route (be it default or non-default) is advertised from two leaf to a ToR, the leaf initially shows only one leaf's links as next hop. When we do clear bgp *, it is then updated. B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:16:52 via 192.168.2.2, PortChannel2, weight 1, 00:16:52 via 192.168.3.2, PortChannel3, weight 1, 00:16:52 via 192.168.4.2, PortChannel4, weight 1, 00:16:52 After doing clear bgp * in tgn-sonic-n2-t1 I can see this B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:00:02 via 192.168.2.2, PortChannel2, weight 1, 00:00:02 via 192.168.3.2, PortChannel3, weight 1, 00:00:02 via 192.168.4.2, PortChannel4, weight 1, 00:00:02 via 192.168.5.2, PortChannel5, weight 1, 00:00:02 via 192.168.6.2, PortChannel6, weight 1, 00:00:02 via 192.168.8.2, PortChannel8, weight 1, 00:00:02 This issue was fixed in PR sonic-net/sonic-buildimage#17184 However a test for this was missing. so this test adds a prefix on 2 T1 neighbors using network command and checks if the advertised route is learnt on the T0 DUT
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this issue
Nov 15, 2024
…the TOR (sonic-net#14683) Description of PR Summary: Fixes # (issue) sonic-net#10837 Orignal Problem In multipath scenario when a route is advertised through network command from two neighbors, only one path is chosen. Doing clear bgp * recovers the device from this scenario. If the same route (be it default or non-default) is advertised from two leaf to a ToR, the leaf initially shows only one leaf's links as next hop. When we do clear bgp *, it is then updated. B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:16:52 via 192.168.2.2, PortChannel2, weight 1, 00:16:52 via 192.168.3.2, PortChannel3, weight 1, 00:16:52 via 192.168.4.2, PortChannel4, weight 1, 00:16:52 After doing clear bgp * in tgn-sonic-n2-t1 I can see this B>* 20.0.0.1/32 [20/0] via 192.168.1.2, PortChannel1, weight 1, 00:00:02 via 192.168.2.2, PortChannel2, weight 1, 00:00:02 via 192.168.3.2, PortChannel3, weight 1, 00:00:02 via 192.168.4.2, PortChannel4, weight 1, 00:00:02 via 192.168.5.2, PortChannel5, weight 1, 00:00:02 via 192.168.6.2, PortChannel6, weight 1, 00:00:02 via 192.168.8.2, PortChannel8, weight 1, 00:00:02 This issue was fixed in PR sonic-net/sonic-buildimage#17184 However a test for this was missing. so this test adds a prefix on 2 T1 neighbors using network command and checks if the advertised route is learnt on the T0 DUT
@dgsudharsan , @wsycqyz , @siqbal1986 , looks like this test gap should have been covered. Can we close this issue to avoid confusion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In one of the manual tests, it is found that advertising through network command might result in issue sonic-net/sonic-buildimage#17183. There is no sonic-mgmt test to cover this scenario. Requesting to add a test to fill this test gap.
Steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Additional information you deem important:
The text was updated successfully, but these errors were encountered: