Update the Wistron platform support in master branch #12110
Conversation
Signed-off-by: RogerX87 <[email protected]>
|
This pull request introduces 15 alerts when merging 9d13a21 into de68f10 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7410e246ba8b3d51f91017e109e66fc5fbfa5832 into 63c14d2 - view on LGTM.com new alerts:
|
Signed-off-by: RogerX87 <[email protected]>
RogerX87
force-pushed
the
wistron_master
branch
from
7410e24 to
7382f3e
Compare
Signed-off-by: RogerX87 <[email protected]>
|
@yxieca @sujinmkang . please help to review, thanks. |
Signed-off-by: RogerX87 <[email protected]>
|
This pull request introduces 11 alerts and fixes 2 when merging 80edd9f into 7087763 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: RogerX87 <[email protected]>
|
This pull request fixes 2 alerts when merging 0949ebc into 7087763 - view on LGTM.com fixed alerts:
|
|
@yxieca @sujinmkang . please help to review, thanks. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
This pull request fixes 2 alerts when merging 9db9193 into 558c904 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging fbd64db into 558c904 - view on LGTM.com fixed alerts:
|
|
@yxieca @sujinmkang it's been hold for a long time, since our customer ask for this, would you please help review and merge it? thanks in advance. |
| from sonic_platform_base.sonic_sfp.sffbase import sffbase | ||
| from sonic_platform_base.sonic_sfp.sff8024 import type_abbrv_name | ||
| from sonic_platform_base.sonic_sfp.sff8024 import type_of_media_interface |
| @@ -141,15 +151,28 @@ def get_reboot_cause(self): | |||
| return (reboot_cause, description) | |||
|
|
|||
| def _get_sku_name(self): | |||
| p = subprocess.Popen(GET_HWSKU_CMD, shell=True, stdout=subprocess.PIPE) | |||
| p = subprocess.Popen(GET_HWSKU_CMD, stdout=subprocess.PIPE) | |||
There was a problem hiding this comment.
what about code under device/wistron directory? The changed file in PR12102 is device/wistron/x86_64-wistron_6512_32r-r0/sonic_platform/chassis.py but I don’t see it here.
There was a problem hiding this comment.
we moved the code from device folder to platform folder.
|
@yxieca please help merge this, thanks in advance. |
|
@prgeor Hi Prince, we had checked the HLD. But our HW design for both 6512_32r and sw_to3200k is to access transceiver eeprom through BMC, not from the i2c interface of CPU, it's quite difficult for us to suit new xcvr design. And the code already had full tested via testbed by customer request, we don't have time to re-factor it since tight schedule. Shall we have this merged first and then get back to open another PR for sfp re-factoring? thanks in advance. |
@RogerX87 https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base/sonic_sfp is going to be purged from the repo by June 2023. Will your platform adapt by then? |
|
@RogerX87 I don't understand why you think sonic_xcvr can support only I2C interface. This is incorrect. Platform can override read and write APIs. For example, This barefoot platform does RPC call to read the eeprom (it also caches the data for performance) https://github.com/sonic-net/sonic-buildimage/blob/master/platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/sfp.py#L105 |
Sure, we will raise another PR for sfp adaption before June 2023. In the mean time, shall we get this PR merged first? |
|
@lguohan can you merge? |
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
Signed-off-by: RogerX87 [email protected]
Why I did it
Update the latest code for better platform support for Wistron platform
How I did it
Modified platform related code in 202111 branch and make it works
How to verify it
Run the codes in Wistron platform
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)