Correct the CodeQL warnings

sonic-net · Oct 27, 2022 · fbd64db · fbd64db
1 parent 2962ef4
commit fbd64db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/device/wistron/x86_64-wistron_6512_32r-r0/plugins/sfputil.py b/device/wistron/x86_64-wistron_6512_32r-r0/plugins/sfputil.py
@@ -111,6 +111,7 @@ def get_presence(self, port_num):
             val_file.close()
         except IOError as e:
             print("Error: unable to access file: %s" % str(e))
+            val_file.close()
             return False
 
         if content == "1":
@@ -134,6 +135,7 @@ def get_low_power_mode(self, port_num):
             val_file.close()
         except IOError as e:
             print("Error: unable to access file: %s" % str(e))
+            val_file.close()
             return False
 
         if content == "1":
@@ -158,6 +160,7 @@ def set_low_power_mode(self, port_num, lpmode):
             return True
         except IOError as e:
             print("Error: unable to open file: %s" % str(e))
+            val_file.close()
             return False
 
     def reset(self, port_num):
@@ -183,6 +186,7 @@ def reset(self, port_num):
             return True
         except IOError as e:
             print("Error: unable to open file: %s" % str(e))
+            val_file.close()
             return False
 
 

diff --git a/platform/innovium/sonic-platform-modules-wistron/6512-32r/sonic_platform/sfp.py b/platform/innovium/sonic-platform-modules-wistron/6512-32r/sonic_platform/sfp.py
@@ -1700,6 +1700,7 @@ def set_lpmode(self, lpmode):
             val_file.close()
             return True
         except IOError:
+            val_file.close()
             return False
 
     def set_power_override(self, power_override, power_set):