Process deprecation of FieldDescriptionInterface::getTargetEntity()

[jorrit]

Subject

It seems that the change from getTargetEntity() to getTargetModel() in #6108 was not fully implemented in the rest of the code. This changeset fixes some deprecation notices I get on runtime and some notices about test classes not implementing FieldDescriptionInterface.

Changelog

I think this internal change does not need a changelog entry.

[phansys]

Good catch @jorrit!

[phansys]

I guess it's RTM. Please, squash your commits.

[jordisala1991]

To fix the build you need to trigger it again. it was a problem with the latest version of prophecy

[phansys]

Thank you @jorrit!

[franmomu]

Hi, this PR should be reverted since FieldDescriptionInterface::getTargetModel is not yet in the interface, so there is no need to implement it yet, it's a BC break. Should be done in 4.x instead.

[jorrit]

I see. The deprecation notices on runtime are unavoidable then? Perhaps the @deprecated annotation can be removed from FieldDescriptionInterface::getTargetEntity() while keeping NEXT_MAJOR: ... because in practice it is not possible to call getTargetModel().

[VincentLanglet]

Hi, this PR should be reverted since FieldDescriptionInterface::getTargetModel is not yet in the interface, so there is no need to implement it yet, it's a BC break. Should be done in 4.x instead.

Indeed, @franmomu @jorrit can someone do the PR ?

[jordisala1991]

Maybe we should check if the class implements the method, if not fallback to the old behavior