Replace some references to "entity" term with "model"#6108
Replace some references to "entity" term with "model"#6108VincentLanglet merged 1 commit intosonata-project:3.xfrom
Conversation
168ae18 to
4746d36
Compare
|
@phansys If you want to fully enforce the agnosticism around the model manager, we have to do something about the following lines SonataAdminBundle/src/Admin/AdminHelper.php Line 233 in 4993aeb SonataAdminBundle/src/Admin/AdminHelper.php Line 253 in 4993aeb We're trying to access to the If we have a getter to avoid using the key Should we create something like an
I maybe can implements this for the next major, since I started something here sonata-project/SonataDatagridBundle#234 WDYT ? Do you have any idea to improve the situation ? |
I agree, but the intention of my PR is not so ambitious. I just wanted to be Doctrine model agnostic, replacing any reference to entity (ORM), document (ODM), etc. I think our next goal should be exactly what you're proposing. In some private projects I'm using this package to handle models from ReST APIs or things like that, but given these limitations I found myself making some nasty tricks in order to make it work.
I've to analyze our API again in order to determine which paths I can identify currently, but IMO the approach you've delineated is in the right way. |
…orce the agnosticism around the model manager
Subject
Replace some references to "entity" term with "model" in order to enforce the agnosticism around the model manager.
I am targeting this branch, because these changes respect BC.
Changelog