Merged
Conversation
ben-taussig-solo
changed the title
ben-taussig-solo
force-pushed
the
fix-build-cache
branch
from
af603d0 to
64cec8c
Compare
jbohanon
reviewed
Mar 1, 2024
Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>
Contributor
Author
|
/skip-changelog CI creds only change |
Contributor
|
This didn't actually have any effect because the |
nfuden
pushed a commit
that referenced
this pull request
Apr 10, 2024
* export BAZEL_BUILD_EXTRA_OPTIONS, GCP_SERVICE_ACCOUNT_KEY_PATH from do_ci.sh * Update ci/do_ci.sh Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * update BAZEL_BUILD_EXTRA_OPTIONS line --------- Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
…inuation cve (#321) * bazel: Update to a newer version of envoy-fork with http2 continuation cve * bazel: Leading space in hash * Use private pool cloud build worker (#316) * use 16core private worker * mimic build-bot's repo tag * sub-job tag * add creds for build cache (#313) * export BAZEL_BUILD_EXTRA_OPTIONS, GCP_SERVICE_ACCOUNT_KEY_PATH from do_ci.sh * Update ci/do_ci.sh Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * update BAZEL_BUILD_EXTRA_OPTIONS line --------- Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * actually save the changes to doci resolution --------- Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Ben Taussig <85883594+ben-taussig-solo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open source companion to https://github.com/solo-io/envoy-gloo-ee/pull/746
One change here is identical to those from that PR:
In addition, this PR exports
BAZEL_BUILD_EXTRA_OPTIONS, explicitly setting the--remote-cachebazel flag to the value ofBAZEL_REMOTE_CACHE, which is currently set byci/cloudbuild.yamlAs you can see in the first PR linked above, this change is also necessary to ensure that envoy-gloo CI targets the proper remote cache URL