Conversation
|
WIP label not to be removed until:
|
|
/kick killed |
|
/kick 💀 |
|
/kick |
…gloo into jbohanon/envoy-1.29
| rm -rf "$ENVOY_DOCKER_BUILD_DIR/envoy/x64/bin/" | ||
| else | ||
| rm -rf "/build/envoy/x64/bin/" | ||
| if [ -z "$BUILD_DIR" ]; then |
There was a problem hiding this comment.
You had mentioned something about this in a comment:
we aren't patching envoy for env vars into do_ci.sh -- we need to set BUILD_DIR because if unset, everything else is overridden in build_setup.sh
Can you say more about this? I think I see the block you're talking about:
if [[ -z "${BUILD_DIR}" ]]; then
echo "BUILD_DIR not set - defaulting to ~/.cache/envoy-bazel" >&2
BUILD_DIR="${HOME}/.cache/envoy-bazel"
fiBut does it matter whether we build in the default location?
| auto sts_factory = StsCredentialsProviderFactory::create(context.api(), | ||
| context.clusterManager()); | ||
| server_context.api(), absl::nullopt /* ServerFactoryContextOptRef context */, | ||
| // We pass an empty string if we don't have a region |
There was a problem hiding this comment.
Should we default to us-east-1?
There was a problem hiding this comment.
after some reflection I think it could be very frustrating to debug issues related to default values in this section -- I think I prefer leaving this as-is
ben-taussig-solo
left a comment
ben-taussig-solo
left a comment
There was a problem hiding this comment.
All comments are nits -- this PR looks good to me
3 participants
No description provided.