Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the newer Solidus event system #284

Merged
merged 2 commits into from
May 3, 2023

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented May 2, 2023

Summary

The old one has been removed on v4.0.

We'll need a major release after this change is merged.

See solidusio/solidus#5024

We're also fixing CI with different changes to our CircleCI config:

  • Run different Solidus versions on different jobs for better error handling.
  • We're now explicitly providing the ruby version to the executor while using a matrix configuration for better extensibility.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Run different Solidus versions on different jobs for better error
handling.

We're now explicitly providing the ruby version to the executor while
using a matrix configuration for better extensibility.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/fix_ci branch from 6a99e83 to d3a9d98 Compare May 2, 2023 10:54
@waiting-for-dev waiting-for-dev self-assigned this May 2, 2023
@waiting-for-dev waiting-for-dev changed the title Update CI configuration Only use the newer Solidus event system May 3, 2023
@waiting-for-dev waiting-for-dev requested review from elia and kennyadsl May 3, 2023 10:33
@kennyadsl
Copy link
Member

@waiting-for-dev specs are failing in the "solidus-older" build against 3.1. But the latest version of the orb doesn't have that version anymore, because it's unsupported. But we are using the @volatile tag, so it should pick the last orb version. Not sure what's happening here.

@waiting-for-dev
Copy link
Contributor Author

@waiting-for-dev specs are failing in the "solidus-older" build against 3.1. But the latest version of the orb doesn't have that version anymore, because it's unsupported. But we are using the @volatile tag, so it should pick the last orb version. Not sure what's happening here.

Thanks for looking into it, @kennyadsl. I think we need a new release for the orb, which is automatically generated when tagged via GH UI/API. I just did it, see https://github.com/solidusio/circleci-orbs-extensions/releases/tag/v0.7.3. I'll re-run the build once the orb is published.

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on dropping support for the failing solidus 3.1?

@waiting-for-dev
Copy link
Contributor Author

Thoughts on dropping support for the failing solidus 3.1?

Yeah, the last orb doesn't cover it anymore.

The old one has been removed on v4.0.

We'll need a major release after this change is merged.

See solidusio/solidus#5024
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/fix_ci branch from c05810b to 04a0a77 Compare May 3, 2023 14:25
@waiting-for-dev waiting-for-dev merged commit b98abd0 into master May 3, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/fix_ci branch May 3, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants