Remove support for legacy event system #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
type:enhancement
github-actions
bot
added
the
changelog:solidus_core
waiting-for-dev
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Thanks, @kennyadsl. There's only one thing to address or a clean git history.
kennyadsl
force-pushed
the
kennyadsl/remove-legacy-events-support
branch
2 times, most recently
from
c4bc28f to
0a393c8
Compare
adammathys
approved these changes
Apr 19, 2023
kennyadsl
force-pushed
the
kennyadsl/remove-legacy-events-support
branch
from
0a393c8 to
9b4af06
Compare
waiting-for-dev
added a commit
to solidusio/solidus_support
that referenced
this pull request
May 2, 2023
The legacy event system is not available since v4.0 [1], so constants won't be available for testing. [1] - solidusio/solidus#5024
3 tasks
waiting-for-dev
added a commit
to solidusio/solidus_subscriptions
that referenced
this pull request
May 3, 2023
The old one has been removed on v4.0. We'll need a major release after this change is merged. See solidusio/solidus#5024
3 tasks
waiting-for-dev
added a commit
to solidusio/solidus_subscriptions
that referenced
this pull request
May 3, 2023
The old one has been removed on v4.0. We'll need a major release after this change is merged. See solidusio/solidus#5024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of 3.x Deprecations Removal.
Summary
This PR removes support for the legacy event system, which has been fully deprecated. Please follow this guide to migrate to the new event system.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: