Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolving arguments in createResource #2353

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

thetarnav
Copy link
Contributor

Check typeof the second argument instead of using the arguments variable.
This fixes case where some arguments were passed explicitely as undefined instead of being omitted.
Which helps with wrapping the resource in own function.

createRecource(fetcher, undefined) // used to cause TypeError: fetcher is not a function

Check typeof the second argument instead of using the `arguments` variable.
This fixes usedase where some arguments were passed explicitely as `undefined` instead of being omitted.
Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: dd83b72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11619987934

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 85.55%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/array.ts 7 80.08%
Totals Coverage Status
Change from base Build 11470124251: 0.5%
Covered Lines: 2291
Relevant Lines: 2612

💛 - Coveralls

@ryansolid ryansolid merged commit 32aa744 into solidjs:main Nov 1, 2024
1 check passed
@ryansolid
Copy link
Member

Thanks.. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants