-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Update start package #660
[FIX] Update start package #660
Conversation
|
Thank you for looking into this. Since start was removed from dependencies, I don't think it makes sense to keep the utilities in a The primitives could be moved to different packages, where it makes sense. @atk @Tommypop2 What do you think? Also there is this: #449 |
It's highly unlikely that these would be accepted into SolidStart. Our goal is to keep it very unopinionated. This would be accepted into MediaKit though... Some of these primitives work outside Start so moving them to the relevant Primitives packages would be a good idea. Then the ones that are Start focused in MK. |
Feel free to propose further changes in new issues/PRs. I'm going to use your changes so far to fix the existing package and rename it to |
So, as I had mentioned in the Solid Discord server, I got the
@solid-community/start
package updated to work with Solid Start version 1 (and didn't even need to include@solidjs/start
as a dependency).THIS PULL REQUEST IS NOT READY TO MERGE
I only opened a pull request, so I could collaborate with the community/team about where to go from here. Ideally, I should probably create a provider and hook for a context, much how it's done with Kobalte UI.
There are a few notable changes so far:
solid-start
is no longer a dev or peer dependency (for obvious reasons, it's unmaintained)pnpn-lock.yaml
, likely because there was a lot of duplication from the old versions ofsolidjs
andsolid-start
floating aroundWhat's next?
Well, I need input from the maintainers (side note: I did not bump the
version
inpackage.json
yet). What do you guys think the next step here. My opinion is that a context is the next step; however, I know this repository focuses on primitives and leaves implementation and expansion to the user. Therefore, I leave it in your guy's hands to determine the course of action. Sadly, this package is no longer usable for it's intended purpose in its current state since Solid Start now doesn't have the oldRoot.tsx
, and anything declared inentry-server.tsx
is non-reactive. Therefore, a context would be the only way to use this with Solid Start.