Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing the refresh_matviews script to be run synchronously. #4632

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

timparsons
Copy link
Contributor

Description

Allowing the refresh_matviews script to be run synchronously.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

Copy link
Member

@bellerbrock bellerbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. The extra time needed for the store germplasm method might be a frustration in larger dbs though. A materialized stockprop refresh takes about two minutes in Cassavabase.

@timparsons
Copy link
Contributor Author

The implementation looks good. The extra time needed for the store germplasm method might be a frustration in larger dbs though. A materialized stockprop refresh takes about two minutes in Cassavabase.

@bellerbrock Yes, agreed. With having the refresh be asynchronous, we found consistency issues due to the view still refreshing while trying to fetch data. Utilizing the synchronous call does mean longer wait time to complete the request, but the data is immediately available from the view. The larger problem to solve may be the materialized views themselves.

@lukasmueller lukasmueller merged commit 74c92f4 into master Sep 12, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/BI-1793 branch September 12, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants