Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list validation to allow variable names without CO number #4631

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Update list validation to allow variable names without CO number #4631

merged 3 commits into from
Oct 12, 2023

Conversation

timparsons
Copy link
Contributor

@timparsons timparsons commented Aug 31, 2023 •
edited
Loading

Description

  1. Update list validation to allow observationVariable names without CO number
  2. The call to refresh the mat. view was changed from asynchronous to synchronous to avoid potential race conditions.

Depends on #4632 being merged first!

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@nmenda
Copy link
Member

nmenda commented Sep 6, 2023

using the variable name instead of the ID for validation is risky since names can change but the IDs are permanent

@lukasmueller
Copy link
Member

Add config variable to change behavior on a instance basis

@timparsons
Copy link
Contributor Author

Add config variable to change behavior on a instance basis

Done

lukasmueller
lukasmueller approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 1b51f65 into master Oct 12, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/BI-1193 branch October 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmenda nmenda nmenda approved these changes

@lukasmueller lukasmueller lukasmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timparsons @nmenda @lukasmueller