Skip to content

program: introduce core BPF tests#8

Merged
buffalojoec merged 7 commits intomainfrom
03-05-program_introduce_core_BPF_tests
Mar 13, 2024
Merged

program: introduce core BPF tests#8
buffalojoec merged 7 commits intomainfrom
03-05-program_introduce_core_BPF_tests

Conversation

@buffalojoec
Copy link
Copy Markdown
Contributor

This PR adds the program tests for the Core BPF implementation. They're pretty
much exactly the same as the original tests, with the feature-gated tests
removed.

@buffalojoec buffalojoec requested a review from lorisleiva March 5, 2024 16:28
Copy link
Copy Markdown
Contributor Author

buffalojoec commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just some small things

Comment thread program/tests/close_lookup_table_ix.rs Outdated
Comment thread program/tests/close_lookup_table_ix.rs
Comment thread program/tests/close_lookup_table_ix.rs Outdated
Comment thread program/tests/common.rs Outdated
Comment thread program/tests/common.rs Outdated
Comment thread program/tests/create_lookup_table_ix.rs
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_implementation branch from 227a8a0 to ac1776b Compare March 7, 2024 18:21
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_tests branch 3 times, most recently from 9ac8eb8 to de8c103 Compare March 8, 2024 16:16
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_implementation branch from f78f0ec to 8fa1a4a Compare March 8, 2024 20:20
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_tests branch 2 times, most recently from 8f9704a to 5ff9010 Compare March 8, 2024 20:44
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just some last little comments

Comment thread program/tests/close_lookup_table_ix.rs Outdated
Comment thread program/tests/close_lookup_table_ix.rs Outdated
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_tests branch 3 times, most recently from ce5da2f to e98fda3 Compare March 12, 2024 18:28
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_implementation branch from e697aa7 to 79db606 Compare March 13, 2024 04:16
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_tests branch from e98fda3 to 2ab95a4 Compare March 13, 2024 04:16
Copy link
Copy Markdown
Contributor Author

buffalojoec commented Mar 13, 2024

Merge activity

  • Mar 13, 12:16 AM EDT: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Mar 13, 12:28 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 13, 12:30 AM EDT: @buffalojoec merged this pull request with Graphite.

@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_implementation branch from 79db606 to f7164f3 Compare March 13, 2024 04:23
@buffalojoec buffalojoec changed the base branch from 03-05-program_introduce_core_BPF_implementation to main March 13, 2024 04:26
@buffalojoec buffalojoec force-pushed the 03-05-program_introduce_core_BPF_tests branch from 2ab95a4 to e6d26d5 Compare March 13, 2024 04:27
@buffalojoec buffalojoec merged commit 51a4462 into main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants